Settings system & Waila update #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seggan
requested changes
Oct 7, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/event/PylonBlockWailaEvent.kt
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/event/PylonEntityWailaEvent.kt
Show resolved
Hide resolved
...core/src/main/kotlin/io/github/pylonmc/pylon/core/guide/button/setting/CycleSettingButton.kt
Outdated
Show resolved
Hide resolved
|
@JustAHuman-xD is there a corresponding base branch for this? |
Yes but I may not have pushed it, I'll check |
|
Any reason it's not PRed? should I wait before reviewing |
Just forgot to |
LordIdra
requested changes
Oct 11, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/waila/WailaConfig.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/guide/pages/SettingsPage.kt
Outdated
Show resolved
Hide resolved
JustAHuman-xD
force-pushed
the
settings-api
branch
from
49d9b45 to
472f6c3
Compare
LordIdra
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #377
Resolves #227 #327 #398 #397
Changes the SettingsPage to have no buttons by default but buttons can be added with SettingsPage#addSetting, adds a waila settings button (which expands into the different options), a resource pack settings option (which holds block texture & armor texture settings), and added a setting for disabling research effects for players.
There are now a few default settings buttons that can be used for simple options (toggles, cycles, and numeric settings), the previously hardcoded toggle & cycle buttons have been removed and have had their usages replaced with these new buttons.
The waila can now be globally disabled by setting the tick interval to be <= 0. I reworked the waila itself a little bit to allow for ActionBar waila and for more configurability, as well as internally changing it to use only 1 raycast call, added events for both block and entity wailas, and added entity waila overrides, as only blocks could have their waila overriden. I also moved the waila out of the blocks package, as it isn't only for blocks.
I remember seeing somewhere a discussion on allowing players to enable the waila for vanilla blocks/entities but I couldn't find an issue for it, but it is implemented by this as well.
While adapting the system I also made it so servers can disable armor textures, and added the option to force block or armor textures as well. (For servers that have a server-side resource pack for ex)